This repository was archived by the owner on Nov 15, 2023. It is now read-only.
wasm-builder: Fall back to release profile for unknown profiles#10775
Merged
wasm-builder: Fall back to release profile for unknown profiles#10775
release profile for unknown profiles#10775Conversation
athei
added
A0-please_review
bkchr
approved these changes
Feb 1, 2022
koute
approved these changes
Feb 2, 2022
agryaznov
pushed a commit
to agryaznov/substrate
that referenced
this pull request
Feb 4, 2022
Wizdave97
pushed a commit
to ComposableFi/substrate
that referenced
this pull request
Feb 4, 2022
This was referenced Mar 4, 2022
grishasobol
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Mar 28, 2022
10 tasks
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recent changes to
wasm-buildermade it error out when a custom profile is used that is notproduction. This breaks the polkadot build which defines thetestnetprofile. We fix this by falling back toreleasefor unknown profiles and outputting a warning.